Surgery Head Reattachment

fix pls
Locked
User avatar
MrJJJ
Registered user
Posts: 1929
Joined: 12 Jan 2015, 10:51
Location: Spider Lab

Surgery Head Reattachment

Post by MrJJJ » 05 Dec 2016, 04:17

Bug Description:
If you try to use say, someones corpse, remove its head, and then re-attach another head, then the head you re-attach will suddenly become the head you removed, and even when you remove it, its not the head you attached, so you have 2 heads of a same person

Steps to reproduce:
1. Grab a corpse in morgue
2. Grab someone's head
3. Remove corpse's head
4. Attach the other head
5. Watch in Amazement how the body still remains the same, and when you try to remove the head, it transformed into the corpse's head that you removed before, leaving you with 2 of them and one angry player

User avatar
Surrealistik
Registered user
Posts: 1595
Joined: 04 Jul 2015, 17:57

Re: Surgery Head Reattachment

Post by Surrealistik » 06 Dec 2016, 15:05

Confirmed. Hella annoying.
Sur 'Druglord' Lahzar; Field Engineer, Perpetually Understaffed and Exasperated CMO/Doctor/Researcher
Bando 'Baldboi' Badderson; PFC, Five foot ten of pure bald glory.

Sur 'Druglord' Lahzar says, "ASS BLAST U-S-A!!!"

User avatar
Snypehunter007
Admin
Admin
Posts: 2601
Joined: 02 Dec 2015, 17:14
Location: Georgia
Byond: Snypehunter007
Contact:

Re: Surgery Head Reattachment

Post by Snypehunter007 » 30 Jan 2017, 19:13

Don't really need to do head reattachment anymore due to lack of cloning.

Asking this to be locked.
► Show Spoiler
Staff History:
► Show Spoiler

User avatar
Surrealistik
Registered user
Posts: 1595
Joined: 04 Jul 2015, 17:57

Re: Surgery Head Reattachment

Post by Surrealistik » 30 Jan 2017, 19:15

Snypehunter007 wrote:Don't really need to do head reattachment anymore due to lack of cloning.

Asking this to be locked.
Might be lower priority but this is sloppy coding that should be fixed.
Sur 'Druglord' Lahzar; Field Engineer, Perpetually Understaffed and Exasperated CMO/Doctor/Researcher
Bando 'Baldboi' Badderson; PFC, Five foot ten of pure bald glory.

Sur 'Druglord' Lahzar says, "ASS BLAST U-S-A!!!"

User avatar
phil235
Dev Team
Dev Team
Posts: 578
Joined: 29 Mar 2017, 20:29
Byond: phil235

Re: Surgery Head Reattachment

Post by phil235 » 09 Sep 2017, 13:33

Codewise, that's more a suggestion than a bug report.

User avatar
Surrealistik
Registered user
Posts: 1595
Joined: 04 Jul 2015, 17:57

Re: Surgery Head Reattachment

Post by Surrealistik » 09 Sep 2017, 13:40

Removing literally transforming heads is a suggestion?
Sur 'Druglord' Lahzar; Field Engineer, Perpetually Understaffed and Exasperated CMO/Doctor/Researcher
Bando 'Baldboi' Badderson; PFC, Five foot ten of pure bald glory.

Sur 'Druglord' Lahzar says, "ASS BLAST U-S-A!!!"

User avatar
phil235
Dev Team
Dev Team
Posts: 578
Joined: 29 Mar 2017, 20:29
Byond: phil235

Re: Surgery Head Reattachment

Post by phil235 » 09 Sep 2017, 14:40

Maybe I misunderstood the bug, is the corpse looking headless after you attach a new head?

User avatar
NGGJamie
Senior Staff
Senior Staff
Posts: 178
Joined: 13 Mar 2017, 07:24
Byond: NGGJamie

Re: Surgery Head Reattachment

Post by NGGJamie » 09 Sep 2017, 15:04

phil235 wrote:
09 Sep 2017, 14:40
Maybe I misunderstood the bug, is the corpse looking headless after you attach a new head?
From what it sounds like, it's a result of the game not considering that the head you're reattaching is someone else's head. So if I have a blue haired snowflake marine who's lost his head, and put a brown-haired marine's decapitated head on them, the brown-haired marines head will now have the blue snowflake hair, and if removed again will show as the snowflake's head.

Most likely because the code doesn't consider WHAT head is put on, just that there's a head there?
My Synthetic Application-Leonard [Accepted]
My Predator Application-Thei-De Na'Tauk [Accepted]

Marine: Jack 'Guns' Croshaw / Lenny Shaw
Synthetic: Leonard
Predator: Thei-De Na'Tauk
Server Status

User avatar
Surrealistik
Registered user
Posts: 1595
Joined: 04 Jul 2015, 17:57

Re: Surgery Head Reattachment

Post by Surrealistik » 09 Sep 2017, 15:22

NGGJamie wrote:
09 Sep 2017, 15:04
From what it sounds like, it's a result of the game not considering that the head you're reattaching is someone else's head. So if I have a blue haired snowflake marine who's lost his head, and put a brown-haired marine's decapitated head on them, the brown-haired marines head will now have the blue snowflake hair, and if removed again will show as the snowflake's head.

Most likely because the code doesn't consider WHAT head is put on, just that there's a head there?
This is exactly what's happening.

The head you attach to a body permanently morphs to match the body it's attached to which is disturbing to say the least.

For example, if I attached Carson's head to Sur's body, Carson's head would become Sur's head.
Sur 'Druglord' Lahzar; Field Engineer, Perpetually Understaffed and Exasperated CMO/Doctor/Researcher
Bando 'Baldboi' Badderson; PFC, Five foot ten of pure bald glory.

Sur 'Druglord' Lahzar says, "ASS BLAST U-S-A!!!"

User avatar
phil235
Dev Team
Dev Team
Posts: 578
Joined: 29 Mar 2017, 20:29
Byond: phil235

Re: Surgery Head Reattachment

Post by phil235 » 09 Sep 2017, 15:52

Yeah, that's asking for code functionality that isn't there, so technically not a bug.

User avatar
Surrealistik
Registered user
Posts: 1595
Joined: 04 Jul 2015, 17:57

Re: Surgery Head Reattachment

Post by Surrealistik » 09 Sep 2017, 16:25

How is that not a bug? That makes no sense whatsoever; I assume that the point of these surgeries is allow you to do things that at least pass the common sense/verisimilitude test
Sur 'Druglord' Lahzar; Field Engineer, Perpetually Understaffed and Exasperated CMO/Doctor/Researcher
Bando 'Baldboi' Badderson; PFC, Five foot ten of pure bald glory.

Sur 'Druglord' Lahzar says, "ASS BLAST U-S-A!!!"

User avatar
NGGJamie
Senior Staff
Senior Staff
Posts: 178
Joined: 13 Mar 2017, 07:24
Byond: NGGJamie

Re: Surgery Head Reattachment

Post by NGGJamie » 09 Sep 2017, 23:42

Surrealistik wrote:
09 Sep 2017, 16:25
How is that not a bug? That makes no sense whatsoever; I assume that the point of these surgeries is allow you to do things that at least pass the common sense/verisimilitude test
Effectively it's such a rare and niche thing that nobody felt the need to store additional data in the head and just store it as that. Making on the fly changes to a Sprite likely wasn't worth the effort to implement for such an uncommon situation.
My Synthetic Application-Leonard [Accepted]
My Predator Application-Thei-De Na'Tauk [Accepted]

Marine: Jack 'Guns' Croshaw / Lenny Shaw
Synthetic: Leonard
Predator: Thei-De Na'Tauk
Server Status

User avatar
Snypehunter007
Admin
Admin
Posts: 2601
Joined: 02 Dec 2015, 17:14
Location: Georgia
Byond: Snypehunter007
Contact:

Re: Surgery Head Reattachment

Post by Snypehunter007 » 10 Sep 2017, 06:30

Surrealistik wrote:
09 Sep 2017, 16:25
How is that not a bug? That makes no sense whatsoever; I assume that the point of these surgeries is allow you to do things that at least pass the common sense/verisimilitude test
Reattaching heads isn't exactly common sense, you can do it in real life for a close casket funeral but it looks unnatural as fuck because all you've done is stitch the base of the head to the neck. No other connections or shit are made.

On a note, we removed head reattachment surgery due to the uselessness of it. Now I don't know why its causing a duplicate head to spawn but I remember we also had that problem before we removed the surgery as well.
► Show Spoiler
Staff History:
► Show Spoiler

User avatar
Surrealistik
Registered user
Posts: 1595
Joined: 04 Jul 2015, 17:57

Re: Surgery Head Reattachment

Post by Surrealistik » 10 Sep 2017, 15:06

Snypehunter007 wrote:
10 Sep 2017, 06:30
Reattaching heads isn't exactly common sense, you can do it in real life for a close casket funeral but it looks unnatural as fuck because all you've done is stitch the base of the head to the neck. No other connections or shit are made.

On a note, we removed head reattachment surgery due to the uselessness of it. Now I don't know why its causing a duplicate head to spawn but I remember we also had that problem before we removed the surgery as well.
It definitely served a purpose when cloning was a thing (or would have if not busted) as per its utility on other servers when you only have the head/brain.

That said, the difference between the rarity of head reattachment and the sheer impossibility of heads literally morphing into other people's heads is pretty conspicuous I feel.

Anyways, if head reattachment is no longer a thing, then there's no need for this bug fix.
Sur 'Druglord' Lahzar; Field Engineer, Perpetually Understaffed and Exasperated CMO/Doctor/Researcher
Bando 'Baldboi' Badderson; PFC, Five foot ten of pure bald glory.

Sur 'Druglord' Lahzar says, "ASS BLAST U-S-A!!!"

User avatar
Snypehunter007
Admin
Admin
Posts: 2601
Joined: 02 Dec 2015, 17:14
Location: Georgia
Byond: Snypehunter007
Contact:

Re: Surgery Head Reattachment

Post by Snypehunter007 » 10 Sep 2017, 15:17

Surrealistik wrote:
10 Sep 2017, 15:06
It definitely served a purpose when cloning was a thing (or would have if not busted) as per its utility on other servers when you only have the head/brain.

That said, the difference between the rarity of head reattachment and the sheer impossibility of heads literally morphing into other people's heads is pretty conspicuous I feel.

Anyways, if head reattachment is no longer a thing, then there's no need for this bug fix.
I meant to say "the uselessness of it, post-cloning". We are currently discussing head reattachment because you can still reattach synth heads.
► Show Spoiler
Staff History:
► Show Spoiler

Locked